Redesign WSL gateway setup and OpenClaw onboard UX#792
Conversation
|
Codex review: needs real behavior proof before merge. Reviewed July 1, 2026, 1:08 AM ET / 05:08 UTC. Summary Reproducibility: yes. from source inspection: open direct OpenClaw onboard, complete the hidden startup-preference flow, and the hidden child toggle can still supply Review metrics: 2 noteworthy metrics.
Merge readiness Overall follows the weaker of proof and patch quality, so missing proof can cap an otherwise strong patch. Rank-up moves:
Proof guidance:
Mantis proof suggestion Risk before merge
Maintainer options:
Next step before merge
Security Review findings
Review detailsBest possible solution: Fix the direct-onboard AutoStart propagation bug, add focused regression coverage, then merge only after maintainers accept the changed defaults and the PR body includes current-head runtime/gateway proof or a clear environment blocker. Do we have a high-confidence way to reproduce the issue? Yes from source inspection: open direct OpenClaw onboard, complete the hidden startup-preference flow, and the hidden child toggle can still supply Is this the best way to solve the issue? No: the latest implementation skips settings-file persistence for direct onboard, but it still allows the tray restart handler to enable Windows startup from the hidden toggle value. The narrower solution is to make hidden-startup-preference completions pass false or preserve the existing setting through the whole completion path. Full review comments:
Overall correctness: patch is incorrect AGENTS.md: found and applied where relevant. Codex review notes: model internal, reasoning high; reviewed against 4166e0fd63f8. Label changesLabel changes:
Label justifications:
Evidence reviewedWhat I checked:
Likely related people:
What the crustacean ranks mean
Shiny media proof means a screenshot, video, or linked artifact directly shows the changed behavior. Runtime, network, CSP, and security claims still need visible diagnostics. How this review workflow works
|
e2f2f28 to
5e5a0e3
Compare
5e5a0e3 to
6d89068
Compare
Remove stale setup screenshots, delete the unused tray SetupWizardWindow and obsolete SetupEngine permissions page, and route direct OpenClaw onboard entry points through the new gateway-installed handoff so users keep the redesigned setup context. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Expose preview-only setup error and OpenClaw onboard error states so the PR screenshot set can cover the recovery UI without checking image artifacts into the repo. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Use the OpenClaw mascot with a corner success badge for the setup complete state, matching the gateway-installed and setup-failed visual language. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Delete the abandoned Onboarding V2 preview harness and visual-diff assets, remove stale lobster branding references, and harden the gateway-installed handoff with inline feedback if onboarding cannot start immediately. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Persist capability profile selections into the runtime node settings used after tray restart, and save the final launch-at-startup choice before restarting the tray. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Ensure capability profile selections are written to the runtime Node* settings used after restart, and persist only the final startup preference when setup completes so direct onboard does not reset existing capability choices. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Start direct onboard windows directly at the gateway-installed handoff and surface permission status read failures inline so setup never silently degrades. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
|
@clawsweeper re-review |
|
🦞🧹 I asked ClawSweeper to review this item again. |
Hide and skip persisting the startup preference for direct OpenClaw onboard sessions so existing AutoStart choices are not overwritten, while fresh setup still defaults startup on. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
|
@clawsweeper re-review |
|
🦞🧹 I asked ClawSweeper to review this item again. |
Summary
Change Type (select all)
Scope (select all touched areas)
winnodeLinked Issue/PR
Validation
Required closeout:
.\build.ps1✅dotnet test .\tests\OpenClaw.SetupEngine.Tests\\OpenClaw.SetupEngine.Tests.csproj --no-restore✅ 363 passeddotnet test .\tests\OpenClaw.Shared.Tests\OpenClaw.Shared.Tests.csproj --no-restore✅ 2686 passed, 31 skippeddotnet test .\tests\OpenClaw.Tray.Tests\\OpenClaw.Tray.Tests.csproj --no-restore✅ 1454 passedAdditional sweep:
dotnet test .\tests\OpenClaw.Connection.Tests\OpenClaw.Connection.Tests.csproj✅ 376 passeddotnet test .\tests\OpenClaw.WinNode.Cli.Tests\OpenClaw.WinNode.Cli.Tests.csproj✅ 120 passeddotnet test .\tests\OpenClawTray.FunctionalUI.Tests\OpenClawTray.FunctionalUI.Tests.csproj✅ 10 passeddotnet test .\tests\OpenClaw.Tray.UITests\OpenClaw.Tray.UITests.csproj -r win-arm64✅ 76 passeddotnet test .\tests\OpenClaw.E2ETests\OpenClaw.E2ETests.csproj✅ 20 skipped (real-gateway gated)dotnet test .\tests\OpenClaw.Tray.IntegrationTests\OpenClaw.Tray.IntegrationTests.csproj✅ 18 skipped (integration-gated)Real behavior proof
win-arm64, isolated tray data.2ca2d214.github.com/user-attachmentsreturned 403 in this environment, so browser-side verification is not re-claimed here.Security Impact (required)
No— no new capability or OS permission surface added.No.No.No.Yes— default capability profile is now Standard instead of silently inheriting the prior full default; users can still choose Full access before install.Yes, explain risk + mitigation: The default is intentionally more explicit and reviewable. The capability profile, relevant Windows permissions, and install review are visible before setup runs.Compatibility / Migration
Yes.No.No.Review Conversations
Rubber-duck review
Final rubber-duck/Hanselman reviews found no blocking issues after fixes. Follow-up cleanups from review were applied: stale Lobster attribution/wording removed, old V2 preview artifacts deleted, direct onboard lock-contention path now surfaces inline feedback, the milestone feedback is a live region for accessibility, selected capability profiles persist into runtime Node* settings, completion persists only AutoStart, direct onboard starts at the milestone without flashing the security page, direct onboard preserves existing startup preferences, and permission-status probe failures show inline warning UI.